Re: [Bug-wget] [Bug--Wget] Issue with RFC 2067 Digest Headers

[Tim Rühsen]

Hi,

we need a check in http.c:3759:
    if (algorithm != NULL && ! strcmp (algorithm, "MD5-sess"))

else we strcmp() with algorithm being NULL.

That should do it.

Regards, Tim

Am Freitag, 12. Juli 2013 schrieb Darshit Shah:
> >
> > I have tried this response and wget just crashes here.  What is the
> > value for `algorithm' at http.c:3763 (current master version,
> > b8f036d16c) when you run it?
> >
> > It doesn't crash for me. I am currently on HEAD^5 and Wget cleanly exits
> here.
> How do I debug Wget when calling it from inside this script?
> 
> 
> > I think we should set the default value to "MD5".
> >
> > Yes, MD5 should be set as the default algorithm.
> 
> 
> > I must specify both algorithm and qop in the response.
> >
> > But those attributes are not required by RFC 2067. Though it is obsolete,
> I guess we should support such servers.
> 
> I will try and debug this more deeply tonight.
> 
> -- 
> Thanking You,
> Darshit Shah
>

signature.asc
Description: This is a digitally signed message part.