[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Bug-Wget][RFC] Improvements to parallel-wget branch

From: Darshit Shah
Subject: Re: [Bug-wget] [Bug-Wget][RFC] Improvements to parallel-wget branch
Date: Thu, 5 Dec 2013 23:36:16 +0530

On Thu, Dec 5, 2013 at 1:38 AM, Giuseppe Scrivano <address@hidden> wrote:

> Darshit Shah <address@hidden> writes:
> > I have been working on making a few changes to the parallel-wget branch.
> > Currently, I am focused on getting all the tests implemented for parallel
> > wget and detection of race conditions. For this, I submit two patches.
> >
> > The first patch, is merely a little cleanup. It removes the redundant
> > --enable-threads options in configure.ac since this option is already
> added
> > automagically for us by threadlib.m4 in GNULib. I have also added
> reporting
> > the status of Metalink Libraries in the configure status message.
> thanks!  I think that is added as a dependency to gettext.  I have done
> some small changes to the commit message (the line was too long) and
> pushed it.
> > The second patch needs a little more work. I am trying to get working on
> > Autotools, but this is one crazy project. I have small issue that isn't
> > working, if anyone can fix this for me, that'd be great!
> > I have added a new configure option, --enable-race-detection. This option
> > when enabled will compile Wget with certain flags which will spew a lot
> of
> > output to the screen on runtime in case it encounters potential race
> > conditions. Hence, this option should NEVER be used on production
> systems.
> > This option must only be used when debugging the code and it is
> preferable
> > to use this option when running the new Test Suite which has tests
> > specifically to fail when this is option is used.
> I have added the missing ChangeLog file entry and pushed the patch as
> well.
Thanks for pushing the patches! But, as I stated earlier, the second patch
has a slight issue.

The variable XFAIL_TESTS isn't being set as expected in testenv/Makefile.am
The RACE_CHECKING_IS_ENABLED variable should ideally be set upon running
the configure script with --enable-race-checking
However, the condition never evaluates to true. Need to look into that.

Thanking You,
Darshit Shah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]