Re: [Bug-wget] [PATCH] Don't use --debug in Test--post-file.px

[Darshit Shah]

I remember writing this code and inadvertently added the debug flag to the
cmdline when debugging the code for errors.

For those who prefer to compile Wget without debug support, this test
should fail. While this patch must be applied for now, I believe that Wget
should silently ignore the --debug flag if it was not compiled with debug
support, instead of failing with an error.

This will not break any backward compatibility, but will be a huge boon for
us. The new test suite in parallel-wget that does not output everything to
stdout, but instead stores the output in separate log files. Hence the
screen will not be un-necessarily cluttered, but for any failing test, we
always have as complete detail as possible for that specific run of Wget.
What do you think of this proposition?

@Lars: It would be great if you could kindly generate a patch file with
`git format-patch` and also add a ChangeLog entry along with it.


On Thu, Jan 23, 2014 at 1:00 PM, Lars Wendler <address@hidden>wrote:

> Test--post-file.px fails when wget is compiled without debugging support.
>
> Signed-off-by: Lars Wendler <address@hidden>
> ---
>  tests/Test--post-file.px | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Test--post-file.px b/tests/Test--post-file.px
> index 1c017b7..1212af6 100755
> --- a/tests/Test--post-file.px
> +++ b/tests/Test--post-file.px
> @@ -8,7 +8,7 @@ use HTTPTest;
>
>
>  
> ###############################################################################
>
> -my $cmdline = $WgetTest::WGETPATH . " -d --post-file=nofile
> http://localhost:{{port}}/";;
> +my $cmdline = $WgetTest::WGETPATH . " --post-file=nofile
> http://localhost:{{port}}/";;
>
>  my $expected_error_code = 3;
>
> --
> 1.8.5.3
>
>
>


-- 
Thanking You,
Darshit Shah