[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Overly permissive hostname matching

From: Jeffrey Walton
Subject: Re: [Bug-wget] Overly permissive hostname matching
Date: Wed, 19 Mar 2014 13:18:09 -0400

On Wed, Mar 19, 2014 at 11:45 AM, Jeffrey Walton <address@hidden> wrote:
> On Wed, Mar 19, 2014 at 11:37 AM, Jeffrey Walton <address@hidden> wrote:
>> On Wed, Mar 19, 2014 at 11:30 AM, Daniel Stenberg <address@hidden> wrote:
>>> On Wed, 19 Mar 2014, Jeffrey Walton wrote:
>>>> # Remove lines that begin with "!"
>>> That sounds wrong:
>>>   A rule may begin with a "!" (exclamation mark). If it does, it is labelled
>>>   as a "exception rule" and then treated as if the exclamation mark is not
>>> present.
>> Oh well. I'm too aggressive on the ban. I'd rather fail closed than open :)
>> Anyway, I'll try to find the meaning of that bang. I seem to recall I
>> could not find the meaning of it in the past.
> After reading that again, I don't mean to sound rude. Sorry about
> that. Thanks for pointing it out.
> And it does bring up a good point: the data structure needs two thing:
> (1) a name, and (2) a flag for white/black. White is white listed
> while black is black listed.
> The API needs (at minimum): (1) take a name, and (2) return
> white/black/no entry. Everything else is just frills.
Something else you may want in the API is a way to determine how,
exactly, a name matched if its a failure. So it might be usefult to
include a Generic Top Level Domain (gTLD), a Country Code Top Level
Domain (ccTLD), or an Effective Top Level Domain from a PSL.

I mention it because my code has some diagnostics in debug builds that
logs the info.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]