[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] [bug-wget] Libpsl for cookie domain checking in Wget
Date: Fri, 06 Jun 2014 11:09:15 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Darshit Shah <address@hidden> writes:

> I'm facing an issue with the patch I submitted for libpsl and would be
> glad if someone could help me.
> The configure.ac file does not work as expected. When libpsl is not
> installed on a system, the LDFLAGS does not contain -lpsl flag, but
> the configure summary shows LIBPSL: Yes.
> There is some discrepency in the output that I'd like to fix. The
> build completes successfully because the HAVE_LIBPSL variable isn't
> set, and Wget compiles without libpsl support. This should however
> happen only when --without-libpsl was explicitly specified as a
> configure option.

does something like this fix the problem for you?  I see other libraries
are using the same pattern, so we should probably fix them as well.

diff --git a/configure.ac b/configure.ac
index d2c2e70..9d4d3f8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -242,8 +242,7 @@ dnl Checks for libraries.
 AS_IF([test x"$with_libpsl" != xno], [
-  with_libpsl=yes
-  AC_CHECK_LIB([psl], [psl_builtin])
+  AC_CHECK_LIB([psl], [psl_builtin], [with_libpsl=yes])

Also, I don't think we should mess with "with_.*" variables and
overwrite them, better define something new for the output message.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]