Re: [Bug-wget] [PATCH] Fix for checking iconv_open return code

[Giuseppe Scrivano]

Tomas Hozza <address@hidden> writes:

> Hi.
>
> Recently I discovered a mistake in wget's source, while browsing is.
> in iri.c function locale_to_utf8() wrongly checked the return code
> of the iconv_open() call [1]. There was "!=" instead of "==".
>
> The patch is attached.
>
> Anyway while trying to reproduce the issue, I realized that the function
> is not used in wget at all. It was introduced in 2008 as part of initial
> IDN support, but then replaced by remote_to_utf8(). So possibly it can
> be completely removed, or the IDN code is not using it by mistake. I didn't
> investigate the issue further.
>
> [1] 
> http://www.gnu.org/savannah-checkouts/gnu/libiconv/documentation/libiconv-1.13/iconv_open.3.html

thanks for the patch.  I've just pushed it with a minor typo fix in the
ChangeLog entry.

Regards,
Giuseppe