bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] Using parallel test harness


From: Tim Ruehsen
Subject: Re: [Bug-wget] [PATCH] Using parallel test harness
Date: Thu, 02 Oct 2014 09:31:12 +0200
User-agent: KMail/4.14.1 (Linux/3.16-2-amd64; KDE/4.14.1; x86_64; ; )

On Wednesday 01 October 2014 22:04:53 Giuseppe Scrivano wrote:
> Tim Ruehsen <address@hidden> writes:
> > While there might be more than one problem, at least one is the naming of
> > the tests. The name given to HTTPServer->new() should always be unique
> > because is is taken as a temporary working directory. Some tests have
> > wrong name (copy&paste I guess) and thus randomly fail when running in
> > parallel !
> > 
> > Here is a patch to fix this.
> > 
> > Tim
> > 
> > From 4a5fd2244545c2c05f40cb7a2dfba7866919d047 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Tim=20R=C3=BChsen?= <address@hidden>
> > Date: Wed, 1 Oct 2014 16:42:04 +0200
> > Subject: [PATCH] fixed test suite race conditions due to double usage of
> > names
> > 
> > ---
> > 
> >  tests/ChangeLog                  | 9 +++++++++
> >  tests/Test--post-file.px         | 2 +-
> >  tests/Test-N-no-info.px          | 2 +-
> >  tests/Test-N-smaller.px          | 2 +-
> >  tests/Test-c-shorter.px          | 2 +-
> >  tests/Test-proxied-https-auth.px | 2 +-
> >  tests/Test-proxy-auth-basic.px   | 2 +-
> >  7 files changed, 15 insertions(+), 6 deletions(-)
> 
> the patch looks correct, I am going to push it soon.

I am sorry to say there is another little problem with dist-check.

run-px is still mentioned in tests/Makefile.am but already removed.

Here is  a small patch to fix this.

Tim

Attachment: 0001-remove-run-px-from-tests-makefile.am.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]