[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Several little patches / fixes
From: |
Tim Ruehsen |
Subject: |
Re: [Bug-wget] Several little patches / fixes |
Date: |
Thu, 30 Oct 2014 11:10:57 +0100 |
User-agent: |
KMail/4.14.2 (Linux/3.16-3-amd64; KDE/4.14.2; x86_64; ; ) |
On Thursday 30 October 2014 09:47:20 Giuseppe Scrivano wrote:
> Tim Ruehsen <address@hidden> writes:
> > Please review and give me a short feedback before I push them.
> >
> > 0001
> > fix memory leak in openssl.c (not freeing X509_NAME_oneline() output) and
> > replaces X509_NAME_oneline() by a RFC 2253 compliant output.
> > From the docs:
> > "The functions X509_NAME_oneline() and X509_NAME_print() are legacy
> > functions which produce a non standard output form, they don't handle
> >
> > multi character fields and have various quirks and inconsistencies.
> >
> > Their use is strongly discouraged in new applications."
> >
> > 0002
> > always set fd to -1 after closing in macro CLOSE_FINISH
> >
> > 0003
> > replaced fd_close by CLOSE_INVALIDATE at two places
> >
> > 0004
> > fixed a memory leak in http.c / gethttp
>
> ACK, they all look fine.
Pushed.
Tim
signature.asc
Description: This is a digitally signed message part.