[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH 5/5] use pkg-config to check gnutls deps if availa

From: Darshit Shah
Subject: Re: [Bug-wget] [PATCH 5/5] use pkg-config to check gnutls deps if available
Date: Sat, 1 Nov 2014 19:33:21 +0530
User-agent: Mutt/1.5.23 (2014-03-12)

On 11/01, Tim Rühsen wrote:
Am Samstag, 1. November 2014, 14:11:53 schrieb Darshit Shah:
I'm in favour of using pkg-config for detection of these libraries and would
like to see the manual checking code gone in a future release.

If we're to merge these patches, all of them should be squashed into one
since they all perform the same action. I've merged all the patches into a
single one and added ChangeLog entry to its right place. If others agree,
I'll push this patch.

Cool, I also would like to see support for pkg-config.

You could add pkg-config for libpsl as well into the patch and check if there
are any other libraries missing.

Oh, I didn't know libpsl ships with pkg-config files. I'll add that in a separate patch.

Also, please consider using AC_SEARCH_LIBS instead of AC_CHECK_LIBS.
A good description why is here: https://autotools.io/autoconf/finding.html

I've been using AC_SEARCH_LIBS, and am currently fixing the configure file, will replace AC_CHECK_LIBS with AC_SEARCH_LIBS.

Here is an example for libz:
AC_ARG_WITH(zlib, AS_HELP_STRING([--without-zlib], [disable gzip compression
support]), with_zlib=$withval, with_zlib=yes)
if test $with_zlib != "no"; then
 AC_SEARCH_LIBS(deflate, z,
   [with_zlib=yes; AC_DEFINE([WITH_ZLIB], [1], [Use zlib])],
   [with_zlib=no;  AC_MSG_WARN(*** ZLIB was not found. You will not be able
to use gzip (de)compression)])


--- end quoted text ---

Thanking You,
Darshit Shah

Attachment: pgpzR4rUxrJJq.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]