Re: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests

[Tim Ruehsen]

On Monday 03 November 2014 14:02:34 Pär Karlsson wrote:
> Attached patch adresses the problem and fixes 'make distcheck' for me.
> Tested under perl-5.20.1 and perl-5.8.9 (all in between should be OK, as
> long as the modules below are installed).
> 
> It might be worth noting (even though the Perl test suite is slowly being
> deprecated(?)) that you need two Perl dependent modules in order to make
> the test suite run at all. They are usually not, AFAIK, bundled with the
> standard perl on most distrubutions, or installed by default:
> 
> * HTTP::Daemon (dev-perl/HTTP-Daemon on Gentoo, libhttp-daemon-perl on
> Debian, etc.)
> * IO::Socket::SSL (dev-perl/IO-Socket-SSL on Gentoo, libio-socket-ssl-perl
> on Debian, etc.)
> 
> In case you don't have those installed, the 'make distcheck' will fail,
> might be worth noting in a README or something.
> 
> Anyway, please review and and check. Should solve the problem :-)
> 
> /Pär

Thanks Pär !

I pushed it.

Tim

signature.asc
Description: This is a digitally signed message part.