[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] Aesthetic changes to progress bar

From: Tim Ruehsen
Subject: Re: [Bug-wget] [PATCH] Aesthetic changes to progress bar
Date: Thu, 20 Nov 2014 11:36:48 +0100
User-agent: KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )

On Wednesday 19 November 2014 23:01:22 Darshit Shah wrote:
> On 11/09, Ángel González wrote:
> >On 07/11/14 06:12, Darshit Shah wrote:
> >>Because real life is catching up, I've very little time till the end of
> >>this year. But I'm going to try and debug this issue and fix it asap.
> >
> >A small suggestion before you stop touching this part of the codebase: do
> >not include the directory-prefix (when set) in the progressbar. Its
> >addition
> >may cause the filename piece to marquee (it's not uncommon that they
> >get long), and it's unnecessary, as the goal of adding --directory-prefix
> >was precisely to prefix every filename with that.
> Attached is a patch that will eliminate the directory prefix from the
> filename displayed in the progress bar.
> I've also added another aesthetic change where if the number of characters
> scrolled is less than 5 (random number I chose), then the filename will not
> be scrolled. This prevents an annoying corner case where only one or two
> characters are scrolled creating a very disturbing effect.

Looks ok to me.


Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]