[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Remove most warnings for missing extern

From: Darshit Shah
Subject: Re: [Bug-wget] Remove most warnings for missing extern
Date: Fri, 21 Nov 2014 19:58:46 +0530
User-agent: Mutt/1.5.23 (2014-03-12)

On 11/21, Tim Rühsen wrote:
On Friday 21 November 2014 17:13:22 Darshit Shah wrote:
Clang provides some warnings for missing extern declarations for non-static
variables. The following two patches clear most of them. I can currently see
only more such warning which is caused by build_info.c. To fix this,
someone will have to hack on the build_info.px perl script.

After ./boostrap

I get

main.c:58:21: fatal error: version.h: No such file or directory
#include "version.h"

I just ran:
make maintainer-clean

and it works for me without any issues. Maybe you could try running a simple make clean first? If it still doesn't work, I'll try looking into it again. But since I can't reproduce it, its hard to guess where the error would be.

Maybe you can also fix these warnings them before pushing:

host.c: In function 'address_list_set_faulty':
host.c:148:55: warning: unused parameter 'index' [-Wunused-parameter]
address_list_set_faulty (struct address_list *al, int index)

cookies.c: In function 'discard_matching_cookie':
cookies.c:303:15: warning: variable 'res' set but not used [-Wunused-but-set-
          int res;

It seems these warnings aren't enabled by -Wall and -Wextra on Clang. In fact -Wunused-but-set-variable is GCC specific only. Which is why I never saw these warnings in my output.

I'll work on these warnings too.

Thanking You,
Darshit Shah

Attachment: pgpp84eBWqKwa.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]