[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a
From: |
Tim Rühsen |
Subject: |
Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test |
Date: |
Sat, 22 Nov 2014 11:30:56 +0100 |
User-agent: |
KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) |
Am Freitag, 21. November 2014, 21:13:45 schrieb Darshit Shah:
> Thanking You,
> Darshit Shah
> Sent from mobile device. Please excuse my brevity
>
> On 21-Nov-2014 8:45 pm, "Tim Ruehsen" <address@hidden> wrote:
> > I had two issues with the above mentioned test.
> >
> > 1. XFAIL is not common to people - we had some confusion on the mailing
>
> list.
>
> Xfail is standard parlance for expected failures. This is also documented
> in the readme file. Xfail is not something we introduced but is available
> in autotools as a standard feature.
>
> > 2. XFAIL is true for a test even if it fails out of *any* reason.
> > Example: When testing on a virtual machine without python3, 'make check'
>
> still
>
> > happily reports XFAIL: 1 instead of report failure of all tests.
>
> This specific issue should be handled in the configure file. I'll try and
> hack it together tomorrow.
>
> I'm against this patch, since currently make check reports exactly as it
> should. The test is expected to fail. I do not know of any scenario where
> this particular test will fail for unexpected reasons. What you describe
> occurs when all tests fail.
>
> Let's keep the expected failures since it is a reminder of features that we
> currently lack.
Darshit, that is something different I wasn't aware of.
You say XFAIL is like a TODO list... well ok.
In this case there should be a (wishlist) bug and it should be referred to
within the test source code. Maybe you can add a description to make clear
what is going on and what is missing in Wget. With that information i could go
and implement it.
Tim
signature.asc
Description: This is a digitally signed message part.
- [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Tim Ruehsen, 2014/11/21
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Darshit Shah, 2014/11/21
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test,
Tim Rühsen <=
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Darshit Shah, 2014/11/22
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Tim Rühsen, 2014/11/22
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Tim Rühsen, 2014/11/22
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Darshit Shah, 2014/11/22
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Tim Rühsen, 2014/11/22
- Re: [Bug-wget] [PATCH] Change testenv/Test-auth-both.py from XFAIL to a normal test, Daniel Stenberg, 2014/11/25
- Re: [Bug-wget] [PATCH] Let Wget select strongest auth challenge, Tim Rühsen, 2014/11/22
- Re: [Bug-wget] [PATCH] Let Wget select strongest auth challenge, Giuseppe Scrivano, 2014/11/26
- Re: [Bug-wget] [PATCH] Let Wget select strongest auth challenge, Tim Ruehsen, 2014/11/26