[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH 6/8] Add extern declaration for program_arsgstring

From: Darshit Shah
Subject: Re: [Bug-wget] [PATCH 6/8] Add extern declaration for program_arsgstring
Date: Mon, 24 Nov 2014 19:21:16 +0530

The argstring in a normal program execution isn't a constant but is
constructed dynamically from the command line options.

The way the argstring is constructed, this var cannot be a const.

Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 24-Nov-2014 7:09 pm, "Giuseppe Scrivano" <address@hidden> wrote:

> Darshit Shah <address@hidden> writes:
> > In test.c, this patch changes the type of program_argstring to char *
> > from a const char *. This is because, we use a char * string in the rest
> > of the program and declare an extern accordingly. Removing the const
> > type helps in keeping the code cleaner at no extra cost.
> > ---
> shouldn't we rather do the other way around and add "const" where
> missed?
> Giuseppe

reply via email to

[Prev in Thread] Current Thread [Next in Thread]