[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH 1-3/3] support HTTP compression

From: Daniel Stenberg
Subject: Re: [Bug-wget] [PATCH 1-3/3] support HTTP compression
Date: Wed, 17 Dec 2014 23:51:28 +0100 (CET)
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)

On Wed, 17 Dec 2014, Ángel González wrote:

+  if (opt.compressed)
+ request_set_header (req, "Accept-Encoding", "gzip, deflate", rel_none);
If we are also supporting compress and bzip2, they should be listed.

bzip2 is not really used by servers to compress text content automatically so there's no point in adding that to Accept-Encoding:. You can still see bzip2 in response headers, but that's for things like bzip2 compressed archives etc.

deflate and gzip are what's being used by servers and what browsers usually ask for.

+  else
    request_set_header (req, "Accept-Encoding", "identity", rel_none);

You should indent lines when they move into else branches.

And why add add "identity" at all in the first place? What good is meant to come out that increased request size?


 / daniel.haxx.se

reply via email to

[Prev in Thread] Current Thread [Next in Thread]