Re: [Bug-wget] [PATCH] Print expected total download size in spider mode

[Rohit Mathulla]

Hi Darshit,

Thanks for reviewing.

On Wed, Feb 18, 2015 at 10:48:02PM +0530, Darshit Shah wrote:
> Hi Rohit,
> 
> Not all servers send a Content-Length header. Some servers send a
> Content-Length header on certain resources, but not on others. What do
> you think is the best way to handle this scenario if we want to print
> the total expected download size in spider mode?
 
I'm not entirely sure. I intended this feature to be best-effort. My use-case 
for this is typically wget --spider -i links; a quick way to know how much 
data will be downloaded. We could simply rename this to say that it is 
estimated 
download size or perhaps count the links which don't send the Content-Length 
header? So, something like

Estimated download size: 100 MB or
Estimated download size: 100 MB (2 links unknown)

What do you think?

> Also I think the total_download_size variable name is easy to confuse
> with other meanings. Maybe we should change it to something that is a
> little more verbose about what it holds. Otherwise, I think the patch
> is mostly fine.
 
How about estimated_download_size?

> However, we are currently in a feature freeze till the next version of
> Wget is released. A couple of weeks I should expect. We can only merge
> your changes after that.

No problem.

Thanks,
Rohit