bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] [Patch] fix bug #39175 Header value length limited with 256


From: Miquel Llobet
Subject: [Bug-wget] [Patch] fix bug #39175 Header value length limited with 256
Date: Thu, 12 Mar 2015 22:02:46 +0100

Increased the header buffer to 8Kb, as there are no limits to the size of
field name, values or headers themselves. While the current value is big
enough, other projects such as Apache [1] or nginx have limits of 4-8Kb.

If we want to allow for arbitrary size headers we should use
resp_header_strdup instead of resp_header_copy, but this new value should
be enough.

--- src/http.c.orig 2015-03-12 21:50:03.000000000 +0100
+++ src/http.c 2015-03-12 21:04:08.000000000 +0100
@@ -1695,7 +1695,7 @@

   char *head;
   struct response *resp;
-  char hdrval[512];
+  char hdrval[8190];
   char *message;

   /* Declare WARC variables. */

[1]: https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestfieldsize

Miquel Llobet


reply via email to

[Prev in Thread] Current Thread [Next in Thread]