bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Patch: Ports test for restrict-filename to python


From: Darshit Shah
Subject: Re: [Bug-wget] Patch: Ports test for restrict-filename to python
Date: Sun, 15 Mar 2015 00:18:13 +0530
User-agent: Mutt/1.5.23 (2014-03-12)

Hi Elita,

Thanks for the contribution! It's a good set of patches that ports some important tests to the Python Test Suite.

However, I had a couple of suggestions. Could you also please retain the comments from the original tests about why that particular filename was chosen? It adds a lot of value to the test when it explains some of the background information.

Also, could you please edit your commit message to be in sync with the GNU ChangeLog style commit messages? Take a look at the existing commit messages for ideas.

--
Thanking You,
Darshit Shah

Attachment: pgpotVpHUV45M.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]