Re: [Bug-wget] 'Test--https.py' and 'Test--https-crl.py' failing when no SSL support

[Tim Rühsen]

Am Montag, 13. Juli 2015, 09:08:10 schrieb Ander Juaristi:
> On 06/22/2015 11:22 AM, Tim Ruehsen wrote:
> > On Sunday 21 June 2015 12:08:39 Ander Juaristi wrote:
> >> Hi all,
> >>
> >> I noticed that when Wget is compiled with no SSL support, two tests from
> >> the>>
> >> Python test suite fail. For me it's always reproducible:
> >>     $ ./configure --without-ssl
> >>     $ make check
> >>     <output trimmed>
> >>     FAIL: Test--https.py
> >>     FAIL: Test--https-crl.py
> >>
> >> This doesn't look like desired behaviour, does it? Ideally, those tests
> >> should be skipped when Wget does not support SSL.
> >>
> >> Isn't there anything like WgetFeature.pm in the Python tests?
> >
> > Today we have the possibility to work with XFAIL_TESTS in Makefile.am.
> >
> > How it should work (IMO):
> > When we './configure --without-ssl' we expect the https tests to FAIL (not
> > just SKIPPED). What we simply need is a SUBST variable that we check in
> > testenv/Makefile.am. Depending on the check the https tests are either
> > added to TESTS or to XFAIL_TESTS. Same with other switchable features.
>
> Hi Tim, sorry for my late response. Just to make sure we can close this
> ticket.
>
> I'm not really sure if I understood your proposed use case. You meant to
> have an environment variable called SUBST that was checked on
> testenv/Makefile.am?

What I meant using AC_SUBST in configure.ac.

I just made up a quick patch using AM_CONDITIONAL (attached).

When you apply it, you have to
$ autoreconf && configure --without-ssl && make check

If it works for you and noone complains would push it to master.

Tim

ssl_tests.diff
Description: Text Data

signature.asc
Description: This is a digitally signed message part.