bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] recur.c compile error


From: Gisle Vanem
Subject: [Bug-wget] recur.c compile error
Date: Fri, 14 Aug 2015 22:03:08 +0200
User-agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33.1

The new reject stuff in recur.c:
  typedef enum
  {
    SUCCESS, BLACKLIST, NOTHTTPS, NONHTTP, 1, 1, PARENT, LIST, REGEX,
    RULES, SPANNEDHOST, ROBOTS
  } reject_reason;

causes errors with MSVC and MingW since in:
  math.h:952:    #define DOMAIN  _DOMAIN i.e. 1
  wingdi.h:1893: #define ABSOLUTE    1

<math.h> is pulled in via some Gnulib headers. And <wingdi.h> via
<windows.h>. I suggest this simple fix:

--- a/src/recur.c   2015-08-14 21:45:44
+++ b/src/recur.c   2015-08-14 21:54:45
@@ -182,6 +182,9 @@
   return ret;
 }

+#undef ABSOLUTE
+#undef DOMAIN
+
 typedef enum
 {
   SUCCESS, BLACKLIST, NOTHTTPS, NONHTTP, ABSOLUTE, DOMAIN, PARENT, LIST, REGEX,

Or better names for the enumerations; 'RR_xx' ?

--
--gv



reply via email to

[Prev in Thread] Current Thread [Next in Thread]