[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Marking Release v1.17.1?

From: Darshit Shah
Subject: Re: [Bug-wget] Marking Release v1.17.1?
Date: Fri, 11 Dec 2015 18:30:24 +0100
User-agent: Mutt/1.5.24+27 (c799162691b2) (2015-08-30)

On 12/11, Giuseppe Scrivano wrote:
Jernej Simončič <jernej|address@hidden> writes:

On Tuesday, December 8, 2015, 21:45:31, Darshit Shah wrote:

With my last set of patches, we have fixed all the issues reported / identified
after the 1.17 release. Hence, maybe we should consider releasing a 1.17.1
bugfix release?

Sorry about reporting this late, it forgot about it a bit: when I was
preparing my Windows release, I noticed that metalink support first
didn't want to compile (due to missing sys/errno.h - just #ifdefing it
out didn't seem to break anything), and then that hash validation
failed, because the file was being opened in text mode. I did a quick
and dirty fix for my build
but this probably isn't correct for non-Windows systems.

Thanks for the patch, one piece is already present upstream, I will
commit the missing part:

From bf56bf4560cef3c1591487e7df1f2cb5e5ad0303 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jernej=20Simon=C4=8Di=C4=8D?=
Date: Fri, 11 Dec 2015 09:58:30 +0100
Subject: [PATCH] * src/metalink.c: Specify 'rb' as mode to open file

src/metalink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/metalink.c b/src/metalink.c
index 986303d..25737b3 100644
--- a/src/metalink.c
+++ b/src/metalink.c
@@ -168,7 +168,7 @@ retrieve_from_metalink (const metalink_t* metalink)
              FILE *local_file;

              /* Check the digest.  */
-              local_file = fopen (filename, "r");
+              local_file = fopen (filename, "rb");
              if (!local_file)
                  logprintf (LOG_NOTQUIET, _("Could not open downloaded 

Another thing that would be nice to include is the taskbar progressbar
This one is based on patch by Ángel González and tbprogress.c from
Gisle Vanem.

Darshit, is there anything left on the progress bar?

This patch affects Windows only. I have no way to test it currently, and it uses Windows-specific constructs that I'm not aware of. I'll have to set up a Windows VM soon for testing these patches.

I will probably tag 1.17.1 later today.


Thanking You,
Darshit Shah

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]