Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys

[moparisthebest]

Hi Tim,

On 03/15/2016 07:50 AM, Tim Ruehsen wrote:
> In wg_pin_peer_pubkey(), what is this loop do {...} while(0) about ?
> I looks like it is not supposed to loop (if it would, we had resource leaks). 
> Maybe you can remove it and instead of 'break: do a 'goto end/cleanup/out' !?

Ah yea that was exactly to fill the place of a goto, I can change that.

> Please consider to use wget_read_file / wget_read_file_free() for reading the 
> contents of a file. It also allows for stdin ('-' at the command line) which 
> makes the new option a bit more consistent with Wget's CLI standards.

I didn't know about those but it sounds nicer, I'll have a go at
changing it to use them.

> Do you plan to create a python test (see testenv/) ?

I'll give that a shot as well.

Thanks much,
Travis

signature.asc
Description: OpenPGP digital signature