[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Keep fetched URLs in POSIX extended attributes
From: |
Tim Ruehsen |
Subject: |
Re: [Bug-wget] [PATCH] Keep fetched URLs in POSIX extended attributes |
Date: |
Fri, 22 Jul 2016 17:27:31 +0200 |
User-agent: |
KMail/5.2.3 (Linux/4.6.0-1-amd64; KDE/5.23.0; x86_64; ; ) |
Thanks for looking more closely than I did, Ander !
On Friday, July 22, 2016 2:22:51 PM CEST Ander Juaristi wrote:
> Hi Sean,
>
> Great patch!
>
> But I just had some unimportant comments about coding style ;D
>
> remove the braces, and indent the if body by two spaces
>
> we use spaces before the parentheses:
> fileno (fp) and strlen (value)
The patch has already been pushed, but feel free to make a follow-up patch
with these things corrected.
> > + /* FreeBSD's extattr_set_fd returns the length of the extended
> > attribute. */ + retval = (retval < 0)? retval : 0;
>
> and before the '?'
I did that before pushing.
Tim
signature.asc
Description: This is a digitally signed message part.