bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH 14/25] New test: Detect when there are no good Met


From: Matthew White
Subject: Re: [Bug-wget] [PATCH 14/25] New test: Detect when there are no good Metalink url resources
Date: Tue, 13 Sep 2016 06:58:44 +0200

On Sun, 11 Sep 2016 22:55:03 +0200
Giuseppe Scrivano <address@hidden> wrote:

> > +MetaXml = re.sub (r'{{FILE1_HASH}}', File1_sha256, MetaXml)
> > +MetaXml = re.sub (r'{{FILE2_HASH}}', File2_sha256, MetaXml)
> > +MetaXml = re.sub (r'{{FILE3_HASH}}', File3_sha256, MetaXml)
> > +MetaXml = re.sub (r'{{FILE4_HASH}}', File4_sha256, MetaXml)
> > +MetaXml = re.sub (r'{{FILE5_HASH}}', File5_sha256, MetaXml)
> > +MetaXml = re.sub (r'{{SRV_HOST}}', srv_host, MetaXml)
> > +MetaXml = re.sub (r'{{SRV_PORT}}', str (srv_port), MetaXml)
> > +MetaFile.content = MetaXml
> 
> and here again could we skip the re module?  ACK with it changed.

Thanks, fixed here and in other patches.

Posting after final decisions are taken about open topics in this series of 
patches.

> 
> Giuseppe

Regards,
Matthew

-- 
Matthew White <address@hidden>

Attachment: pgpxLdXAb7z7V.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]