bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disp


From: Giuseppe Scrivano
Subject: Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing
Date: Sun, 25 Sep 2016 19:52:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hi Matthew,

Matthew White <address@hidden> writes:

> [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, 
> contrib/check-hard is ok]
>
> This implements the auto-processing of Metalink files part of a 
> "Content-Type: application/metalink4+xml" header answer.
>
> e.g.:
> $ wget --metalink-over-http \
>        --metalink-index=inf \
>        [--content-disposition \]
>        [--trust-server-names \]
>        [--header="Accept: */*,application/metalink4+xml" \]
>        <url answering with a "Content-Type: application/metalink4+xml">
>
> The following description is verbatim from the patch:
> -----
> Process the Content-Type header, identify an application/metalink4+xml
> file.  The Content-Disposition could provide an alternate name through
> the "filename" field for the metalink xml file.  Respectively, the cli
> options --metalink-over-http and --content-disposition are required.
>
> When Metalink/XML auto-processing, to use the Content-Disposition's
> filename, the cli option --trust-server-names is also required.
> -----

this looks fine to me as well.

Could you please re-send the updated series?

I had some problems applying your patches, as some comments from the
emails got into the patch itself, could you try with git send-email?

Thanks,
Giuseppe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]