Re: [Bug-wget] [PATCH 21/27] New option --metalink-index to process Metalink application/metalink4+xml

[Matthew White]

Hi Giuseppe,

On Thu, 29 Sep 2016 22:31:21 +0200
Giuseppe Scrivano <address@hidden> wrote:

> Hi Matthew,
> 
> Matthew White <address@hidden> writes:
> 
> > diff --git a/src/init.c b/src/init.c
> > index 6729c5a..26f3886 100644
> > --- a/src/init.c
> > +++ b/src/init.c
> > @@ -248,6 +248,7 @@ static const struct {
> >    { "login",            &opt.ftp_user,          cmd_string },/* 
> > deprecated*/
> >    { "maxredirect",      &opt.max_redirect,      cmd_number },
> >  #ifdef HAVE_METALINK
> > +  { "metalinkindex",    &opt.metalink_index,     cmd_number_inf },
> >    { "metalinkoverhttp", &opt.metalink_over_http, cmd_boolean },
> >  #endif
> >    { "method",           &opt.method,            cmd_string_uppercase },
> > @@ -385,6 +386,10 @@ defaults (void)
> >       bit pattern will be the least of the implementors' worries.  */
> >    xzero (opt);
> >  
> > +#ifdef HAVE_METALINK
> > +  opt.metalink_index = -1;
> > +#endif
> > +
> >    opt.cookies = true;
> >    opt.verbose = -1;
> >    opt.ntry = 20;
> > diff --git a/src/main.c b/src/main.c
> > index ac6ee2c..d48e3b2 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -354,6 +354,7 @@ static struct cmdline_option option_data[] =
> >      { "rejected-log", 0, OPT_VALUE, "rejectedlog", -1 },
> >      { "max-redirect", 0, OPT_VALUE, "maxredirect", -1 },
> >  #ifdef HAVE_METALINK
> > +    { "metalink-index", 0, OPT_VALUE, "metalinkindex", -1 },
> >      { "metalink-over-http", 0, OPT_BOOLEAN, "metalinkoverhttp", -1 },
> >  #endif
> >      { "method", 0, OPT_VALUE, "method", -1 },
> > @@ -714,6 +715,8 @@ Download:\n"),
> >      N_("\
> >         --keep-badhash              keep files with checksum mismatch 
> > (append .badhash)\n"),
> >      N_("\
> > +       --metalink-index=NUMBER     Metalink application/metalink4+xml 
> > metaurl ordinal NUMBER\n"),
> 
> "Metalink" should be lower case.

With "Metalink" I meant the standard/protocol Metalink/HTTP, the HTTP should be 
implied by application/metalink4+xml, hence it is missing.

Once the Patch v2 26/27 
http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00157.html is applied, 
"Metalink" may refer to a plain HTTP header too of application/metalink4+xml 
type.

This is why I prefer to use "Metalink" and not "Metalink/HTTP".

> 
> Giuseppe

Regards,
Matthew

-- 
Matthew White <address@hidden>

pgpNn9wve0WXN.pgp
Description: PGP signature