Re: [Bug-wget] Fwd: New Defects reported by Coverity Scan for GNU Wget

[Tim Ruehsen]

 while ((n = FILE_SYSTEM_PREFIX_LEN (p)) > 0)

in two places should silence them all four.

On Friday, September 30, 2016 11:56:41 AM CEST Darshit Shah wrote:
> ---------- Forwarded message ----------
> From: <address@hidden>
> Date: 30 September 2016 at 11:42
> Subject: New Defects reported by Coverity Scan for GNU Wget
> To: address@hidden
> 
> 
> 
> Hi,
> 
> Please find the latest report on new defect(s) introduced to GNU Wget found
> with Coverity Scan.
> 
> 4 new defect(s) introduced to GNU Wget found with Coverity Scan.
> 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the
> recent build analyzed by Coverity Scan.
> 
> New defect(s) Reported-by: Coverity Scan
> Showing 4 of 4 defect(s)
> 
> 
> ** CID 1363354:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
> /src/metalink.c: 971 in ()
> 
> 
> ____________________________________________________________
> ____________________________________________
> *** CID 1363354:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
> /src/metalink.c: 971 in ()
> 965
> 966       /* Remove prefix drive letters if required, i.e. when in w32
> 967          environments.  */
> 968       p = new;
> 969       while (p[0] != '\0')
> 970         {
> 
> >>>     CID 1363354:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
> >>>     use of "=" where "==" may have been intended
> 
> 971           while ((n = FILE_SYSTEM_PREFIX_LEN (p)))
> 972             p += n;
> 973
> 974           if (p != new)
> 975             {
> 976               while (ISSLASH (p[0]))
> 
> ** CID 1363353:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
> /src/metalink.c: 1015 in ()
> 
> 
> ____________________________________________________________
> ____________________________________________
> *** CID 1363353:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
> /src/metalink.c: 1015 in ()
> 1009
> 1010       if (!name)
> 1011         return NULL;
> 1012
> 1013       basename = last_component (name);
> 1014
> 
> >>>     CID 1363353:  Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)
> >>>     use of "=" where "==" may have been intended
> 
> 1015       while ((n = FILE_SYSTEM_PREFIX_LEN (basename)))
> 1016         basename += n;
> 1017
> 1018       return metalink_check_safe_path (basename) ? basename : NULL;
> 1019     }
> 1020
> 
> ** CID 1363352:  Control flow issues  (DEADCODE)
> /src/metalink.c: 972 in replace_metalink_basename()
> 
> 
> ____________________________________________________________
> ____________________________________________
> *** CID 1363352:  Control flow issues  (DEADCODE)
> /src/metalink.c: 972 in replace_metalink_basename()
> 966       /* Remove prefix drive letters if required, i.e. when in w32
> 967          environments.  */
> 968       p = new;
> 969       while (p[0] != '\0')
> 970         {
> 971           while ((n = FILE_SYSTEM_PREFIX_LEN (p)))
> 
> >>>     CID 1363352:  Control flow issues  (DEADCODE)
> >>>     Execution cannot reach this statement: "p += n;".
> 
> 972             p += n;
> 973
> 974           if (p != new)
> 975             {
> 976               while (ISSLASH (p[0]))
> 977                 ++p;
> 
> ** CID 1363351:  Control flow issues  (DEADCODE)
> /src/metalink.c: 1016 in get_metalink_basename()
> 
> 
> ____________________________________________________________
> ____________________________________________
> *** CID 1363351:  Control flow issues  (DEADCODE)
> /src/metalink.c: 1016 in get_metalink_basename()
> 1010       if (!name)
> 1011         return NULL;
> 1012
> 1013       basename = last_component (name);
> 1014
> 1015       while ((n = FILE_SYSTEM_PREFIX_LEN (basename)))
> 
> >>>     CID 1363351:  Control flow issues  (DEADCODE)
> >>>     Execution cannot reach this statement: "basename += n;".
> 
> 1016         basename += n;
> 1017
> 1018       return metalink_check_safe_path (basename) ? basename : NULL;
> 1019     }
> 1020
> 1021     /*
> 
> 
> ____________________________________________________________
> ____________________________________________
> To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.
> net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-
> 2Bd2MGckcRZIqiw5BQEQ9vrzwIdaOu6EyzrI-2BoVm-2FEMS-
> 2BtEEzxnwMw-3D-3D_kmui4qaulLL-2B3aqI2t0AqcRL86AEPYbxN-
> 2BCgq0zmT00BmekYpSJJUGM33Yx8V8baKh7kRlNSwetdfieonCGGzJ4QYVxH
> vfMMGl76aCePsL34gbPPb7dxn4Id1d9deuC9Y7BAxKjjbp-
> 2FftNVBnHuXVkezFqLRfeG4lq81MODUy-2BMiZj7vctaLyII1IYmfMEzP0imR8H
> 154WxDDAYuyuuhvg-3D-3D
> 
> To manage Coverity Scan email notifications for "address@hidden", click
> https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-> 
> 2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-
> 2FA8y06Nq4TvwZ2eDmcOCUJLMeJKuafOsXG7DLig-2B-2FtTyxF8I6BdKjCNNNE0p1fBHEAYJw
> xxK4JPbFe1L0xnM-2BlTMyiOorikRvRyowLpuAxiVSoFemksE-3D_kmui4qaulLL-
> 2B3aqI2t0AqcRL86AEPYbxN-2BCgq0zmT00BmekYpSJJUGM33Yx8V8
> baVNeKutSl02CFyJ5s2Gh89FWKoJo430K-2FSUWJN5QbrFwqT6beqV9pm786up9rv-2B-
> 2B7WeH7unIGYBj8WjyGXB26xYIUWiQSTbtX9lGHKwrEuC3hAUzcretaon-
> 2FYWNWSKDrufoSireY9nW-2FYOgzJGnOdQA-3D-3D

signature.asc
Description: This is a digitally signed message part.