[Bug-wget] [bug #50219] ftp.c calls abort() under certain error conditions

[Tim Ruehsen]

URL:
  <http://savannah.gnu.org/bugs/?50219>

                 Summary: ftp.c calls abort() under certain error conditions
                 Project: GNU Wget
            Submitted by: rockdaboot
            Submitted on: Fri 03 Feb 2017 11:40:55 AM CET
                Category: Program Logic
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: trunk
        Operating System: None
         Reproducibility: None
           Fixed Release: None
         Planned Release: None
              Regression: None
           Work Required: 1 - Days
          Patch Included: None

    _______________________________________________________

Details:

A potential long runner like Wget should never call abort().

In src/ftp.c are some switch() with incomplete testing and defaulting to call
abort(). This may stop Wget randomly.

Example:
ftp.c, L585+:
err = ftp_syst ...
switch (err)...

'err' may become WRITEFAILED on write errors. This is not cased by the switch
and would got into the default case that calls abort().

Solution:
Never call abort(). Instead print a precise error message and return the error
to the calling function.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50219>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/