Re: [Bug-wget] patch: Improve the rolling file name length for downloading progress image when without NLS

[Tim Ruehsen]

On Thursday, February 16, 2017 9:19:26 PM CET YX Hao wrote:
> Hi Guys,
> 
> The algorithm to locate the string sequence, which is for scrolling long
> file name in the downloading progress animation, is hard ;p
> 
> The only problem is the 'cols_to_bytes' function for no NLS feature, which
> returns wrong bytes number should be copied! I guess.
> 
> Will some body take a review for my patch in previous email?
> 
> Windows platform users can download a same problem executable file from
> https://eternallybored.org/misc/wget/ .
> You will see the right to the file name's last character part, that won't be
> updated when the file name is scrolling. And, the last character will be
> reproduced progressively on the screen :(

I would like to get rid of USE_NLS_PROGRESS_BAR.
It is a shortcut for
        HAVE_WCWIDTH && HAVE_MBTOWC

gnulib provides us with these functions on systems, where they don't exist in 
the standard C library.

For a quick check, could you unconditionally set USE_NLS_PROGRESS_BARin wget.h 
(lines 78 and 80-83 should be commented), recompile wget and report if it 
works for you ?

Regards, Tim

signature.asc
Description: This is a digitally signed message part.