|
From: | Darshit Shah |
Subject: | Re: [Bug-wget] `make check` fails 4 tests on fresh wget2 clone |
Date: | Thu, 23 Mar 2017 11:21:37 +0100 |
User-agent: | NeoMutt/20170306-53-323bf4 (1.8.0) |
However, when building with IDNA, we may make IDNA 2008 (libidn2) the minimum requirement. For this, the important thing to look at is which platforms / systems will suffer. Far as I am aware, most distros and platforms have libidn2 available as a package, but if there are systems where this is not the case, we should evaluate whether we would like to drop full compatibility for such systems.
Anyways, this boils down to:1. IDNA is not a hard build dependency. Hence, we should detect for its absence and ignore running tests that depend on it. 2. We make libidn2 (IDNA 2008 + TR46) the minimum library version required for IDNA support.
* Tim Ruehsen <address@hidden> [170323 10:08]:
On Thursday, March 23, 2017 1:07:12 PM CET Avinash Sonawane wrote:Hello! I just cloned the fresh wget2 repo and did `make check` but it failed for 4 tests. I haven't configured to use valgrind. Is this an expected behavior? Here is the tests/test-suite.log http://pastebin.com/g1crJBJ7 PS - No. I'm not using proxy connection. Also I haven't set any proxy variables.You should have libidn2/libidn2-dev (IDNA 2008 + TR46) installed. If that is not possible, the old libidn/libidn-dev (IDNA 2003, suffers from some security issues, but still pretty common) will do it in this case as well. BTW, the curl project recently decided to use libidn2 only. If you don't have either, wget2 is still compilable but just works with pure ASCII domain names. BTW, the message 'toASCII not available:' is directly in the code you are just working on (wget_str_to_ascii()) :-) We could: 1. Skip those tests if IDNA is not available 2. Make IDNA 200x a hard build prerequisite WDYT ? Regards, Tim
-- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
signature.asc
Description: PGP signature
[Prev in Thread] | Current Thread | [Next in Thread] |