Re: [Bug-wget] PATCH: tests for SSL

[Vijo Cherian]

Attached now.

On Tue, May 2, 2017 at 8:06 AM, Vijo Cherian <address@hidden> wrote:

> Sorry about that Tim.
> I reworked the patches again.
> This time, I ran 'make check -j4" in a loop overnight.
>
> Best,
> Vijo.
>
> On Sun, Apr 30, 2017 at 5:49 AM, Tim Rühsen <address@hidden> wrote:
>
>> Hi Vijo,
>>
>> maybe I miss something ?
>>
>> $ cat tests/Test-https-pfs.log
>> Running test Test-https-pfs
>> IO::Socket::IP configuration failed at SSLServer.pm line 71.
>> Failed to get ssl sock at SSLServer.pm line 168.
>> Can't call method "accept" on an undefined value at SSLServer.pm line 86.
>>
>> Regards, Tim
>>
>> On Samstag, 29. April 2017 13:21:04 CEST Vijo Cherian wrote:
>> > Thank you for your review and comments, Tim.
>> >
>> > Attached is the revised set of patches for the same tests.
>> >
>> >
>> > Best,
>> > Vijo.
>> >
>> > On Fri, Apr 28, 2017 at 3:42 AM, Tim Rühsen <address@hidden> wrote:
>> > > Hi Vijo,
>> > >
>> > > great work !
>> > >
>> > > There is just a bit of polishing to be done... :-)
>> > >
>> > >
>> > > - some whitespace warnings (maybe you set your editor to remove
>> trailing
>> > > whitespace when saving !?):
>> > >
>> > > .git/rebase-apply/patch:516: trailing whitespace.
>> > > my $revokecmd = "openssl ca -config $caconf -revoke $servercrt &&
>> > > .git/rebase-apply/patch:795: trailing whitespace.
>> > > issuerAltName=issuer:copy
>> > > .git/rebase-apply/patch:802: trailing whitespace.
>> > >
>> > >  certificate = $dir/interca.crt
>> > >
>> > > .git/rebase-apply/patch:865: trailing whitespace.
>> > > issuerAltName=issuer:copy
>> > > .git/rebase-apply/patch:872: trailing whitespace.
>> > >
>> > >  certificate = $dir/test-ca-cert.pem
>> > >
>> > > warning: 5 lines add whitespace errors.
>> > >
>> > >
>> > > - you use the 'openssl' tool from the tests.
>> > > Is it possible to create the required files apart from the tests and
>> > > store them in tests/certs ? You can provide a script and/or a README
>> how
>> > > to create these files (see testenv/certs/README).
>> > > If that is not possible, the tests should see if the 'openssl' command
>> > > is available. If unavailable the test(s) should SKIP.
>> > >
>> > >
>> > > - some tests fail here with 'make check -j4' but succeed with -j1
>> > > (failures are a bit random):
>> > > FAIL: Test-https-tlsv1.px
>> > > FAIL: Test-https-tlsv1x.px
>> > > FAIL: Test-https-clientcert.px
>> > >
>> > >
>> > > - this test always fails (wget is build with GnuTLS):
>> > > FAIL: Test-https-badcerts.px
>> > >
>> > > Releasing 0x0000559c258a74d0 (new refcount 1).
>> > > GnuTLS: ASN1 parser: Error in DER parsing.
>> > > Closed fd 3
>> > > Unable to establish SSL connection.
>> > > Can't use an undefined value as a symbol reference at SSLServer.pm
>> line
>> > > 131.
>> > > Test failed: wrong code returned (was: 4, expected: 5)
>> > > FAIL Test-https-badcerts.px (exit status: 255)
>> > >
>> > >
>> > >
>> > > With Best Regards, Tim
>> > >
>> > > On 04/27/2017 06:19 AM, Vijo Cherian wrote:
>> > > > Thank you Tim.
>> > > >
>> > > > Attached is the last set of patches from me for SSL testing.
>> > > > I will apply these to wget2 and start working on wget2 from now.
>> > > >
>> > > > Best,
>> > > > Vijo.
>> > > >
>> > > > On Wed, Apr 19, 2017 at 4:12 AM, Tim Rühsen <address@hidden>
>> wrote:
>> > > >> Hi Vijo,
>> > > >>
>> > > >> On 04/18/2017 06:56 PM, Vijo Cherian wrote:
>> > > >>> Added a framework for perl based SSL tests, and some tests to
>> start
>> > >
>> > > with.
>> > >
>> > > >>> In case this is of interest, I will add more tests for SSL: client
>> > > >>> certificates, CRLs, negative tests etc.
>> > > >>> Also not included : making these tests a part of "make check".
>> > > >>>
>> > > >>> TESTING :  only on ubuntu 16
>> > > >>
>> > > >> thank you for this contribution !
>> > > >>
>> > > >> Your commit has been slightly amended (trailing white space
>> removed,
>> > > >> commit message changed to GNU style) and pushed to master.
>> > > >>
>> > > >> Maybe you are interested to inspect Wget2 testing to see if your
>> tests
>> > > >> are already covered there. If not we would be pleased if you could
>> add
>> > > >> them there as well.
>> > > >>
>> > > >> Just 'git clone https://github.com/rockdaboot/wget2' and jump in !
>> > > >>
>> > > >> Regards, Tim
>>
>>
>

0001-Added-new-tests-for-SSL.patch
Description: Text Data