[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] http server responding with 416 but file was not transfer
Re: [Bug-wget] http server responding with 416 but file was not transferred completely
Thu, 14 Sep 2017 19:47:38 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
On 14.09.2017 17:06, Tim Rühsen wrote:
> On 09/14/2017 12:11 PM, Josef Moellers wrote:
>> On 14.09.2017 10:12, Tim Rühsen wrote:
>>> On 09/14/2017 09:53 AM, Josef Moellers wrote:
>>>> We have seen (at least) one server who has
>>>> Accept-Ranges: bytes
>>>> in his header but, upon receiving a request with
>>>> Range: bytes=23068672-
>>>> responds with
>>>> HTTP/1.1 416 Requested Range Not Satisfiable
>>>> although the file was not transferred completely!
>>>> wget then claims that
>>>> The file is already fully retrieved; nothing to do.
>>>> wget https://downloads.dell.com/FOLDER02721216M/1/SUU_18.104.22.168.ISO
>>>> the, after a couple of MB, abort the transfer and then continue the
>>>> wget --continue
>>>> Maybe the check in src/http.c:
>>>> 3821 if (statcode == HTTP_STATUS_RANGE_NOT_SATISFIABLE
>>>> 3822 || (!opt.timestamping && hs->restval > 0 && statcode ==
>>>> 3823 && contrange == 0 && contlen >= 0 && hs->restval >=
>>>> should be changed and any HTTP_STATUS_RANGE_NOT_SATISFIABLE with an
>>>> incomplete file should show something like
>>>> "download continue failed, file incomplete"
>>> Well, that would be ok for this special server.
>>> Normally 416 together with a server timestamp matching the file's
>>> timestamp means that the file is complete (as far as the client can
>>> judge from HTTP).
>>> IMO, if the server is broken (or misbehaves) then the server should be
>>> repaired. Except it is a very common misbehavior. In which case we could
>>> consider a work-around on the client side.
>> So I humbly propose the attached patch.
>> I tried to create a pull request, but got a 403.
> Thanks for the patch - I'll test it in the next days.
I have attached a simple webserver that simulates the error:
when a request with a Range comes in, it replies with 416 and also
returns an unsanely huge Content-Length. You'll need glib2 and
microhttpd for it to build.
I was able to reproduce the issue with this server and check that the
patch fixes it by causing wget to retry (until --retries is exhausted).
> BTW, we currently work on Wget2 where we have a related issue, if you
> like to take a look at it: https://gitlab.com/gnuwget/wget2/issues/278
I'll do that.
Description: OpenPGP digital signature