[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable ch
From: |
Eli Zaretskii |
Subject: |
Re: [Bug-wget] Patch: Fix printing mutibyte characters as unprintable characters on Windows |
Date: |
Sun, 05 Nov 2017 17:42:30 +0200 |
> From: "YX Hao" <address@hidden>
> Cc: <address@hidden>
> Date: Sun, 5 Nov 2017 23:01:22 +0800
>
> >> '_getmbcp' is used
> > Maybe the problem is that the codepage used for the console output is
> > different from the system's ANSI codepage? What does GetConsoleOutputCP
> > return in the case you describe?
> >
> > What happens if ENABLE_NLS is defined? Your patch only handles the
> > situation where ENABLE_NLS is NOT defined.
>
> Yes, my patch only handles the situation I meet with, by using necessary
> predefined conditions. I leave the others untouched, because I don't have
> the needed libraries.
> I hope others who has the environments can test it and turn on the switches
> when necessary.
>
> And I can tell you that 'GetConsoleOutputCP' returns the codepage as command
> 'chcp'. It is right. The gnu 'vsnprintf' doesn't work right with 'setlocale'
> omitted.
Sorry, I don't follow. Does GetConsoleOutputCP return the same value
as _getmbcp, or does it return a different value?