[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to loc

From: Tim Rühsen
Subject: Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded
Date: Sun, 12 Nov 2017 14:50:47 +0100
User-agent: KMail/5.2.3 (Linux/4.13.0-1-amd64; KDE/5.37.0; x86_64; ; )

On Donnerstag, 2. November 2017 21:09:46 CET YX Hao wrote:
> Dear Tim,
> The 2nd patch is attached. Please take a review :)

Hmmm, is this a stand-alone patch and working without your patch #1 (Fix 
printing...) ?

Please give at least one example (better more) to show what your patch fixes.
Even better: write a small python test in testenv which fails without your 
patch and succeeds with your patch. That would protect against regressions.

As I understand, the second patch is still in discussion with Eli. Since I do 
not have Windows, I can't help you here. Though what I saw from the 
discussion, you address a portability issue that likely should be solved 
within gnulib. Maybe you could (in parallel) send a mail to address@hidden 
with a link to your discussion with Eli. There might be some people with 
deeper knowledge.

With Best Regards, Tim

Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]