Re: [PATCH] Allow running tests in testenv on a different wget binary

[Tim Rühsen]

On 11/21/19 10:46 AM, Tomas Hozza wrote:
> 
> 
> On 8. 11. 2019 14:05, Tomas Hozza wrote:
>> On 7. 11. 2019 20:53, Tim Rühsen wrote:
>>> On 07.11.19 15:22, Tomas Hozza wrote:
>>>> Hello.
>>>>
>>>> I would like to reuse upstream tests in testenv/ for testing official 
>>>> Fedora build of wget, installed on the system. Currently tests hardcode 
>>>> path to wget binary to ../src/wget. I added option to set WGET_PATH 
>>>> environment variable to path to a wget binary, which is then used when 
>>>> running tests. This is completely optional, and if not specified, tests 
>>>> work as they did before. However if specified e.g. to "/usr/bin/wget", the 
>>>> distribution-specific build of wget is tested instead.
>>>
>>> Hi Tomas,
>>>
>>> thanks for that ! We just recently discussed about running the test with
>>> wget2. Your patch makes it possible. Just pushed it with an amended
>>> commit message.
>>>
>>> BTW, did you consider to use WGET_PATH for the perl tests as well ?
>>>
>>> Regards, Tim
>>>
>>
>> Hi Tim.
>>
>> I did consider that, but since I'm no Perl expert and have been contributing 
>> new tests mostly to the Python test suite, I didn't spend time on it. I may 
>> have a look at it, but I can not promise when that will be.
>>
>> Regards,
>> Tomas
>>
> 
> Hi Tim.
> 
> I still don't see the change in wget's git 
> (http://git.savannah.gnu.org/cgit/wget.git/log/?h=master). Did you really 
> push it there?

Sorry, Tomas.

It was stuck in the branch I am currently working on. Now pushed to
master :-)

Regards, Tim

signature.asc
Description: OpenPGP digital signature