Re: [PATCH] Don't print message about loading crl or ca-cert files with --no-verbose

[Tim Rühsen]

Hi Tomas,

On 24.03.20 14:24, Tomas Hozza wrote:
> Hi.
> 
> I would like to get feedback on a subtle change of behavior in wget
> between version 1.14 and the current upstream version, which has
> been pointed out by our distribution users.
> 
> Before change [1], wget didn't produce any output related to loading CA
> certificates when --no-verbose option has been used. When --no-verbose
> option is used, only error messages and basic information should get
> printed. Information about loading CRL or CA certificate is probably not
> a basic information. Any error when loading the CRL or CA certificate
> will be still printed with --no-verbose.

The behavior has not been changed, but has been introduced by two blocks
code blocks, as pointed out by you in [1].

It looks to me that before that commit, --ca-certificate was a no-op
when Wget was built with GnuTLS, while --crl-file was introduced as a
new option then.
That explains why nothing has been output before, no matter what
verbosity had been chosen.

While users should not rely on or expect certain output information
(except when documented), I appreciate your patch and pushed it to master.

Thank you very much !

Regards, Tim

> 
> Some users rely on wget not printing such information and they consider
> it a regression.
> 
> Reported as https://bugzilla.redhat.com/show_bug.cgi?id=1807267
> 
> I'm attaching a patch which makes wget to print the message about
> loading CRL or CA certificate file only in verbose mode (the default).
> 
> [1] 
> http://git.savannah.gnu.org/cgit/wget.git/commit/?id=e4a8fe84e2b813b65d91aec29298eecabe4850a5
> 
> Regards,
> Tomas
>

signature.asc
Description: OpenPGP digital signature