[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-xorriso] [PATCH] acinclude: fix LIBBURN_ASSERT_VERS_LIBS for ou

From: Thomas Schmitt
Subject: Re: [Bug-xorriso] [PATCH] acinclude: fix LIBBURN_ASSERT_VERS_LIBS for out-of-tree builds
Date: Thu, 04 Apr 2019 18:29:15 +0200


> The test for symbol versioning assumes that the build is happening in the
> source tree, so use $srcdir so the test works with out-of-tree builds.

Thank you for your patch.
Now i only need to understand the problem.

LIBBURN_ASSERT_VERS_LIBS tests for linker support of option --version-script.
If this test succeeds the option is added to LIBLDFLAGS, if it fails for
some reason, then the ./configure script reports
  disabled strict symbol encapsulation (test failed)
The negative effect would be that internally global symbols of libburn
get visible to applications which link libburn.so.
So it could lure application developers into using such symbols which
are not intended for public use.

Is this what you experienced ?
Do you agree with my assessment of the consequences ?

If so, then libisofs and libisoburn will need similar changes.


I will test your patch with my normal build situation.

Can you give me instructions how to achieve your situation ?
I have to confess that my autotools knowledge is strictly heuristic.

Have a nice day :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]