[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-zile] Re: small patches

From: Reuben Thomas
Subject: [Bug-zile] Re: small patches
Date: Tue, 2 Mar 2010 15:53:09 +0000

On 2 March 2010 09:54, Giuseppe Scrivano <address@hidden> wrote:
> Hello,
> First of all, thanks for this great software!  I tried to build zile
> from code and I had to change few things to get it built.  I would
> suggest you to consider the following small patches I have attached:

Thanks very much for your patches.

> 1) autogen.sh honors GNULIB_SRCDIR if it is defined, in this way you
>   don't need to have gnulib-tool in your PATH.

I have used this one, thanks.

> 2) Update the code to accomodate new versions of gnulib, the only change
>   required is to use "gl_xlist.h" instead of "gl_list.h".

As far as I can tell, the point of using the xlist module is that it
catches out of memory errors, is that correct? I have used it. I have
also removed an include of "gl_list.h" from variables.c, which doesn't
need it, as it already includes main.h; it seems that extern.h should
also include gl_xlist.h.

> 3) If LUA is not found, signal an error, configure will not succeed.

I don't understand this change: Lua is not needed to build released
sources, only git sources.

I have recently noticed a cosmetic problem in Zile which I will now
try to fix, so if you want to make any further comments, please do so
quickly, before the next release!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]