[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-zile] Re: [PATCH] Check `fchmod' and `fchown' return value.

From: Reuben Thomas
Subject: [Bug-zile] Re: [PATCH] Check `fchmod' and `fchown' return value.
Date: Tue, 2 Mar 2010 20:54:15 +0000

Thanks for the patch. The thing is, we really do not care if the operations succeed or fail. So, normally I would just cast the return value to void, but the GNU Coding Standards do not allow that.

Also, there is no need to fix both fchown and fchmod, as only one of them causes a warning.

What do you think?

On 2 March 2010 20:33, Giuseppe Scrivano <address@hidden> wrote:
This patch fixes the following compiler warning:

warning: ignoring return value of 'fchown', declared with attribute warn_unused_result



reply via email to

[Prev in Thread] Current Thread [Next in Thread]