[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-zile] Zee anastasis in progress!

From: Reuben Thomas
Subject: Re: [Bug-zile] Zee anastasis in progress!
Date: Sun, 14 Oct 2012 01:41:50 +0100

I've done the code review of C Zee. I have a couple of things left to
integrate, in the terminal display, but the vast bulk is done. I have
a handful of other TODOs to do.

As a bonus, I found and fixed one more inefficiency, in reading the
file: it slurped into a Lua string, then made an AStr from that. It
now reads directly into an AStr, using alien to bind read. This looks
like it ought to go in luaposix, but while it's easy to have
polymorphic arguments in Lua functions (as I have done in lrexlib for
searching AStrs directly) it's not obviously possible to have
polymorphic return types without some way of indicating what type you
want back, which will necessitate changing the interface to
read/write, e.g. by adding a flag indicating that you'd like a raw
memory block rather than a string, or perhaps even giving a
constructor function (more complicated, but more flexible). One to
think about.

The commits are a bunch of big gloopy messes, sorry.

On the other hand it's pretty easy to examine the code to find useful
patches for Zile/Zi, and even if I'd separated out the commits they
wouldn't on the whole have applied cleanly: Zee is just too different.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]