Re: [Ccrtp-devel] missing memory desallocation

[glodas]

Hi,

we've found another problem in source.cpp:212 in the function
RTPApplication::findCNAME you call const char
*InetAddress::getHostname(void) const
(inaddr.cpp from package commonc++ 1.0.8) which is buggy

inaddr.cpp :
   382         if(hp)
   383                 return hp->h_name
hp points on the stack variable hb which content points on the stack
array hbuf.
hp->h_name is removed from the stack at the end of the function, so the
pointer is no more valid,

As you seem to be involved in common c++ too... ;)

Guillaume Fraysse,
Guillaume Glodas




Le mer 02/04/2003 à 13:37, David Sugar a écrit :
> We can do a 1.0.1 this week if nessisary.
> 
> Federico Montesino Pouzols wrote:
> 
> >     Hi,
> >
> >     it is fixed in CVS. ccRTP 1.0 has been released the last week,
> >so the leak will be fixed in 1.0.1. Note that 1.0 comes with an
> >important bug fix with respect to 1.0pre2, so I recommend you to
> >upgrade.
> >
> >On Wed, Apr 02, 2003 at 10:48:08AM +0200, Guillaume FRAYSSE wrote:
> >  
> >
> >>Hello,
> >>
> >>While lokking for memory leaks with valgrind in an application we've 
> >>written we found one in ccRTP, in the class TRTPSessionBase in  rtp.h, the 
> >>dso and cso object are never desallocated.
> >>
> >>We fixed this in the endSocket method like this :
> >>
> >>inline void
> >>endSocket()
> >>{ 
> >>        dso->endSocket(); 
> >>        cso->endSocket();
> >>        if (dso) delete dso; dso = NULL;
> >>        if(cso) delete cso; cso = NULL;
> >>}
> >>
> >>We use the pre2 but I didn't see a fix in the CVS repository neither.
> >>Will this be fixed in a later release ?
> >>
> >>Hope this helps,
> >>Cheers,
> >>Guillaume
> >>
> >>
> >>_______________________________________________
> >>Ccrtp-devel mailing list
> >>address@hidden
> >>http://mail.gnu.org/mailman/listinfo/ccrtp-devel
> >>    
> >>
> >
> >
> >_______________________________________________
> >Ccrtp-devel mailing list
> >address@hidden
> >http://mail.gnu.org/mailman/listinfo/ccrtp-devel
> >  
> >
> 
>