chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] ⌦PATCH⌫ cond-expand + error for .egg files


From: felix . winkelmann
Subject: Re: [Chicken-hackers] ⌦PATCH⌫ cond-expand + error for .egg files
Date: Sun, 18 Nov 2018 19:45:01 +0100

> address@hidden wrote:
> > 2 patches: first one fixes the problem that program components
> > are not considered when resolving component dependencies,
>
> Pushed, thanks :)
>
>
> > second adds "cond-expand" + "error" forms to the egg specification
> > format and resurrects "chicken-install"s "-feature" option.
>
> It looks fine, but I have one question: does it make sense to keep the
> cond-expand clauses in the installed egg-info file? Shouldn’t the expanded
> version be installed instead, to avoid losing some information about how the
> egg was compiled?

That's actually a very good idea, but complicates the implementation.
Currently we just add a bunch of forms. With your suggested change,
we need to rewrite the egg spec as it is interpreted. Not too difficult,
though.


felix




reply via email to

[Prev in Thread] Current Thread [Next in Thread]