Re: [Chicken-hackers] [PATCH] Some small debugger data and wire protocol improvements

[Peter Bex]

On Sun, Jul 22, 2018 at 11:45:17PM +1200, Evan Hanson wrote:
> Hello hackers,
> 
> Here are a few small changes to the debugging backend, to address some
> snags I hit into while working on a program that uses the debugger
> protocol. As the commit message says, they're intended to "simplify the
> use of the debugging protocol by client applications by fixing a few
> oddities that would otherwise need to be coded around on the client
> side." If you have any questions, just let me know.

Hi Evan,

I've finally gotten around to taking a look and even though I don't
know all that much about the debugger, the change looks fine.

One thing though; I think we need to add some sort of versioning support
to the debugger protocol so when you run feathers to talk to a program
compiled with a different version of CHICKEN, this is going to fail.

I think this is a situation we ought to at least detect and warn or error
on, so the user won't be left with confusing behaviour.  This is quite
likely when you consider the debugger can be used remotely; there is no
guarantee that the program on the remote end is using the same version
of the debugger protocol.

> I also have an accompanying patch to update the debugger-protocol egg,
> which can be applied once this looks OK to you.

Please do!

Cheers,
Peter

signature.asc
Description: PGP signature