[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] chicken-do: Avoid buffer overrun when prep
felix . winkelmann
Re: [Chicken-hackers] [PATCH] chicken-do: Avoid buffer overrun when preparing Windows command line
Tue, 01 Jan 2019 03:19:29 +0100
> Hello, here's a fix for a bug I encountered while testing Felix's recent
> patch on Windows.
> The buffer used for the command line executed by chicken-do had size
> MAX_PATH, but that's quite short (only 260) so the program would almost
> always write beyond it and into the locals passed to CreateProcess(),
> causing that call to fail. This patch grows the buffer to the maximum
> length handled by CreateProcess() and adds a check for truncation.
Thanks for this, pushed, and a happy new year to you all!