[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: #1781: http-client: Always include a path component when sending a p
From: |
Chicken Trac |
Subject: |
Re: #1781: http-client: Always include a path component when sending a proxy request |
Date: |
Mon, 06 Sep 2021 06:21:42 -0000 |
#1781: http-client: Always include a path component when sending a proxy request
--------------------------------+----------------------
Reporter: sjamaan | Owner: sjamaan
Type: defect | Status: assigned
Priority: major | Milestone: someday
Component: unknown | Version: 5.2.0
Resolution: | Keywords:
Estimated difficulty: easy |
--------------------------------+----------------------
Comment (by sjamaan):
Nope, that didn't fix it because uri-common has a hateful behaviour where
it tries to "normalize" the path in a way that doesn't actually match the
real situation.
This is not ideal for this particular piece of code, but it is helpful
when trying to manipulate paths in a sane way. And since uri-common makes
the promise/guarantee never to mutate the input unless you explicitly do
so yourself, it can't really avoid doing this at the readout level (note
that when you write an empty path it will normalize it too, so then it
will have the right value). So while I'm not 100% sure we should keep it,
it's probably still fine.
Anyway, I've worked around this by also checking for the empty faked out
root path in 4c32441.
There's still some behaviour I want to investigate before making a new
release - it looks like the client is disconnecting when it is receiving a
404. A quick study of the http-client code seems to indicate we're not
doing it there, so maybe it's mitmproxy (or the upstream server even?)
which is disconnecting.
--
Ticket URL: <https://bugs.call-cc.org/ticket/1781#comment:3>
CHICKEN Scheme <https://www.call-cc.org/>
CHICKEN Scheme is a compiler for the Scheme programming language.