Re: [cp-patches] [Patch] JNI method checking during build time

[Tom Tromey]

>>>>> "Michael" == Michael Koch <address@hidden> writes:

Michael> I have written the attached patch to check at build time if
Michael> all needed JNI methods are implement and no old/obsolete JNI
Michael> method exists anymore.  This makes the build fail when the
Michael> JNI methods get borked.

I think this is a great idea.

Michael> Ok to commit ?

I think the script is great, but see below.

Michael> +noinst_DATA = check_jni_methods
Michael> +check_jni_methods:

It is better to use all-local for this sort of thing.
You might also want to consider how this interact with rebuilding the
headers.  It probably makes more sense to put the checking rule in
include/Makefile.am and have it depend on $(H_FILES).

Tom