Re: [cp-patches] [generics] RFC : implementation of jjava.lang.instrument package

[Nicolas Geoffray]

Hi Mark,

Mark Wielaard wrote:

> My idea was even that a VM might only want to have one redefine
> prepare/apply cycle running at the same time. Then it can easily cleanup
> anything not used. But this might be optimizing for an unusual case. We
> can probably assume that transformers will actually transform correctly.
>
>  
You're deleting all shared code I came up with :) I switched
to your idea because it reduces the number of native methods.

> Aha. Sorry I missed the dual nature of the
> ClassFileTransFormer.transform() method. I see you documented this in
> your original patch. In that case I really do think we should move these
> to vm/reference/java/lang and make this method package private.
>
>  
Which method? callTransformers? It's a method from the
InstrumentationImpl class, therefore it's in
gnu/java/lang/instrument. Would you like InstrumentationImpl
to be in vm/reference/java/lang/InsutrumentationImpl? This sounds
weird. We could also make the callTransformers method public.

> Right, I see we need to break the VM interface for this :{
> Probably best not to do that for the first release (0.20) but lets
> suggest how we would like to change the interface for 0.21 so runtime
> implementers can prepare and scream about it. On the other hand this is
> the generics branch only, not very many VMs depend on it yet. But not
> very urgent I guess before we have this working with at least one VM.
>
>  
I'm working on it (the jnjvm can now execute with the generics branch,
yeah :)). OK for making suggestions, where should it be written?

> > Just make a new paragraph for Instrumentation. Then mention that it
> > currently only is on the generics branch since it uses some new language
> > features.
> >
> >    
OK then.

Cheers,
Nicolas