classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Re: [commit-cp] classpath ./ChangeLog vm/reference/gnu/clas


From: Mark Wielaard
Subject: [cp-patches] Re: [commit-cp] classpath ./ChangeLog vm/reference/gnu/classpat...
Date: Sat, 17 Dec 2005 13:36:43 +0100

Hi Keith,

On Fri, 2005-12-16 at 15:17 -0800, Keith Seitz wrote:
> Indeed! I got a little ahead of myself. I've committed the attached 
> patch which should fix it. (This time I even waited for the build to 
> finish. O:-)

Thanks for fixing this so quickly. One small request for next time.

> +     catch (Exception e)
> +       {
> +         /* Really not much we can do. For now, just print out
> +            a warning to the user. */
> +         System.out.println ("Jdwp.notify: caught exception: " + e);
> +       }
> [...]
> +       // !! May need to implement send queue?
> +       synchronized (jdwp._connection)

Please use "standard" comment markers FIXME or TODO to make it easier to
scan through a package to see what items still need work.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]