[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Inappropriate use of synchronized in PlainSocketImpl: Submit for Cl
Re: Inappropriate use of synchronized in PlainSocketImpl: Submit for Classpath
28 Jun 2001 08:24:47 -0400
Gnus/5.0803 (Gnus v5.8.3) Emacs/20.7
"Wu, Gansha" <address@hidden> writes:
> We have modified GNU Classpath so that ORP with Classpath can
> run Volano. Here is the first of the patches needed for that.
> We found that Classpath's implementation of PlainSocketImpl(in
> java/net/PlainsocketImpl.java) overused synchronized keyword
> before almost all the native methods such as read, write,
> etc.. Generally speaking native socket implementation(e.g.,
> Winsock) takes the responsibility for thread-safety, and if we
> raise the responsibility up to Java language level, there'll be
> problems here in multi-threaded senarios.
I can see the problem you're talking about given your explanation. I
can make these changes but I won't be able to inspect our native code
on this until I get to the point of merging these with gcj. Aaron,
you want to make a comment?
Brian Jones <address@hidden>