classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

A minor bug in java.io.File: Submit for Classpath


From: Wu, Gansha
Subject: A minor bug in java.io.File: Submit for Classpath
Date: Fri, 29 Jun 2001 09:48:53 +0800

    We found a minor bug in java.io.File when we tried to run Volano benchmark 
on ORP with Classpath.
    Here's the senario:
            File file = new File(System.getProperty(propname), filename);
    While System.getProperty(propname) return null, then the constructor:
           File(String dirname, String name){
                   this(dirname + separator + name);
           }
           assumes that a file with filename must exist under the directory 
named "null". 
    An approperiate modification is to add a check like this:
          this(dirname == null?name:dirname + separator + name);
    The context compare result below is based on gnu classpath cvs snapshot of 
June 22.Note that revision number is different from public CVS.

Index: java/io/File.java
===================================================================
RCS file: /home/gwu2/cvsroot/classpath/java/io/File.java,v
retrieving revision 1.1.1.1
diff -c -r1.1.1.1 File.java
*** java/io/File.java   2001/06/25 01:13:33     1.1.1.1
--- java/io/File.java   2001/06/28 08:02:00
***************
*** 295,301 ****
  public
  File(String dirname, String name)
  {
!   this(dirname + separator + name);
  }

  /*************************************************************************/
--- 295,301 ----
  public
  File(String dirname, String name)
  {
!   this(dirname == null?name:dirname + separator + name);
  }

  /*************************************************************************/
        




reply via email to

[Prev in Thread] Current Thread [Next in Thread]